Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Commit

Permalink
Closes #293 - review: Clarify a11y hack comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
mcomella committed Jan 16, 2018
1 parent 421464f commit 82a8db5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/src/main/res/layout/fragment_new_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
on the state of the checkbox child. However, unlike for TextViews, VoiceView does not read the
checked state of child CheckBoxes so we have to work around this:
When VoiceView is enabled, we dynamically change focusability so the parent layout is
When VoiceWiev is enabled, we sacrifice consistency in visual highlighting in order to get the
correct content description by dynamically changing focusability so that the parent layout is
unfocusable and we focus the CheckBox instead, which announces the correct data. Since the
TextView is no longer spoken, we dynamically set the contentDescription of the CheckBox to the
text of the TextView to cause them to have the same announcement.
Expand Down

0 comments on commit 82a8db5

Please sign in to comment.