Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1827716 - Remove adveritising of TWA support in AndroidManifest #1965

Merged
merged 4 commits into from
May 19, 2023

Conversation

jonalmeida
Copy link
Collaborator

@jonalmeida jonalmeida commented May 9, 2023

This is the last remaining part to remove that was started in mozilla-mobile/android-components#12024.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1827716

@jonalmeida jonalmeida added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 9, 2023
@jonalmeida jonalmeida requested a review from mcarare May 9, 2023 19:45
@Amejia481 Amejia481 added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels May 16, 2023
@jonalmeida jonalmeida added the 🛬 needs landing PRs that are ready to land label May 19, 2023
@mergify mergify bot merged commit af0e01a into mozilla-mobile:main May 19, 2023
@jonalmeida
Copy link
Collaborator Author

@Mergifyio backport releases_v114

@mergify
Copy link
Contributor

mergify bot commented May 23, 2023

backport releases_v114

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants