For #17802: Match the design for three-dot menu navigation

[eliserichards]

For #17802
Wait for #17838 to be merged (✅ merged)

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[mergify]

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

[codecov-io]

Codecov Report

Merging #17875 (c52a62d) into master (8b7279e) will decrease coverage by 0.15%.
The diff coverage is 2.56%.

@@             Coverage Diff              @@
##             master   #17875      +/-   ##
============================================
- Coverage     33.00%   32.84%   -0.16%     
+ Complexity     1416     1383      -33     
============================================
  Files           461      461              
  Lines         19472    19430      -42     
  Branches       2988     2719     -269     
============================================
- Hits           6426     6382      -44     
- Misses        12391    12512     +121     
+ Partials        655      536     -119     

Impacted Files	Coverage Δ	Complexity Δ
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt	3.84% <2.56%> (+0.52%)	2.00 <0.00> (ø)
...fenix/trackingprotection/TrackingProtectionMode.kt	0.00% <0.00%> (-81.25%)	0.00% <0.00%> (-2.00%)
...pp/src/main/java/org/mozilla/fenix/ext/Activity.kt	20.00% <0.00%> (-70.00%)	0.00% <0.00%> (ø%)
.../main/java/org/mozilla/fenix/theme/ThemeManager.kt	9.75% <0.00%> (-31.71%)	0.00% <0.00%> (-5.00%)
...ain/java/org/mozilla/fenix/perf/StartupTimeline.kt	55.55% <0.00%> (-27.78%)	2.00% <0.00%> (-2.00%)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt	6.39% <0.00%> (-17.67%)	14.00% <0.00%> (-14.00%)
...rc/main/java/org/mozilla/fenix/perf/Performance.kt	10.00% <0.00%> (-10.00%)	2.00% <0.00%> (-2.00%)
...g/mozilla/fenix/downloads/DynamicDownloadDialog.kt	0.00% <0.00%> (-6.78%)	0.00% <0.00%> (ø%)
...nix/components/toolbar/BrowserToolbarController.kt	89.65% <0.00%> (-1.73%)	0.00% <0.00%> (ø%)
...e/intent/FennecBookmarkShortcutsIntentProcessor.kt	91.66% <0.00%> (-1.67%)	5.00% <0.00%> (ø%)
... and 74 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7279e...5b05a2d. Read the comment docs.

[gabrielluong]

It was a bit hard for me to tell what the changes were about based on the issue name. Could we also reword it to something like: Move the menu navigation toolbar based on the toolbar orientation

[eliserichards]

@gabrielluong the acceptance criteria in the issue is pretty extensive, you can see what changes were made there

[gabrielluong]

@gabrielluong the acceptance criteria in the issue is pretty extensive, you can see what changes were made there

I can only note 2 particular things that the PR does from looking at the code:

• Moving the menu navigation toolbar based on the toolbar orientation
• Removing the bookmark from the menu navigation toolbar

Since the latter is rather minor, I think the suggested naming of the issue of just addressing the first issue still makes the primary headline. We can add the latter point into the commit description as well or have it as a separate commit. I think I am still looking for the original requested changes?

[gabrielluong]

I think I am still waiting for the changes on the original feedback?

[eliserichards]

I think naming it as matching the design will point them to the issue so they can see the fine details. This naming encompasses all of the changes, instead of just mentioning one change

[gabrielluong]

Looks good, thank you for the changes!

[mergify]

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏