Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Swiping up/down while reddit loads shows toolbar placeholder #18034

Closed
Mugurell opened this issue Feb 17, 2021 · 11 comments
Closed

[Bug] Swiping up/down while reddit loads shows toolbar placeholder #18034

Mugurell opened this issue Feb 17, 2021 · 11 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 17, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  • New app install -> to not have set how to open Reddit -> to have Reddit show a banner asking about this
  • Access reddit.com
  • swipe up/down while Reddit loads

Expected behavior

  • Maybe the toolbar should be fixed in place?

Actual behavior

  • The toolbar is animated away from the screen but a placeholder for it is shown.
RedditToolbarIssue.mp4

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org Feature:Toolbar Address bar, see also Feature:Search labels Feb 17, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 17, 2021
@Mugurell Mugurell removed the needs:triage Issue needs triage label Feb 17, 2021
@Mugurell
Copy link
Contributor Author

Duplicate of #14821

@Mugurell Mugurell marked this as a duplicate of #14821 Feb 17, 2021
@Mugurell
Copy link
Contributor Author

Reopening this since in the linked #14821 there seems to be more issues described while here there is a specific one.

@Mugurell
Copy link
Contributor Author

Looked into possible approaches and one easy way to fix this exact case would be to just not animate the toolbars while the webpages are loading.
Chrome seems to do the same and Sorina recommended the same in #10200.
Confirmed with Nicole that if this straightforward approach solves the issue we should go with it.

@Mugurell
Copy link
Contributor Author

Added P1 back as a priority from Vesta.

@Mugurell Mugurell reopened this Feb 22, 2021
@Mugurell Mugurell mentioned this issue Feb 24, 2021
Closed
@Mugurell
Copy link
Contributor Author

Created https://bugzilla.mozilla.org/show_bug.cgi?id=1694730 as a GV followup to the Fenix/AC changes which would block the toolbar from animating while the lab loads. This is not enough.

@Mugurell
Copy link
Contributor Author

Setting E5 as estimation for all the Fenix and AC changes + GV followups.

@Mugurell Mugurell added the E5 Estimation Point: about 5 days label Feb 24, 2021
@Mugurell Mugurell self-assigned this Feb 25, 2021
Mugurell added a commit that referenced this issue Mar 4, 2021
@Mugurell
For #18034 - Don't animate the toolbar while the tab is loading
cf483ef 
Use the new controller offered by AC to resolve some browser layout issues and
also offer an experience consistent with that of other browsers.
@Mugurell
Copy link
Contributor Author

Removing this from Kanban since it's waiting for GV.
Will keep an eye for when things change so continue the work on it.

@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Apr 6, 2021 •
edited
Loading

This issue is no longer reproducible. Verified on latest Nightly (210406 05:01 - GV89), Beta (GV: 88.0-20210404185932) and Firefox Daylight v87.0.0-rc.1 (Build #2015799099). Managed to reproduce with the build from the date the issue was logged on (Nightly 210217 17:01).
Device used: HTC Nexus 9 with Android 7.1.1.

@sflorean
Copy link
Contributor

sflorean commented Apr 6, 2021

Issue is still reproducible for the following case:

  1. Open reddit.com.
  2. Wait for the page to load and scroll up, in order to hide the toolbar.
  3. Check the Reddit banner.

Expected: no visual issues are displayed.
Actual: the placeholder for toolbar is displayed, when the banner is ON.

Not reproducible when the page is loading, and the toolbar is fixed.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#18034 - Don't animate the toolbar while the tab is…
9305a41 
… loading

Use the new controller offered by AC to resolve some browser layout issues and
also offer an experience consistent with that of other browsers.
This was referenced Aug 13, 2021
Closed
Merged
@Mugurell
Copy link
Contributor Author

@ QA: The last part with the toolbar expanding when the bottom banner appears should be resolved after mozilla-mobile/android-components#10805. Please help verify.

@Mugurell Mugurell added the eng:qa:needed QA Needed label Aug 18, 2021
@SoftVision-LorandJanos
Copy link

The toolbar works as expected on the latest Nightly build (93.0a1 - 2021-08-25T05:10:54.365489).
Verified using the following devices:

  • Google Pixel 4 (Android11).
  • Xiaomi Mi11 Lite (Android 11).
  • LG Nexus 5 (Android 6.0.1).

Closing the ticket as verified. Removing the QA needed label.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mugurell @SoftVision-LorandJanos @sflorean