Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Changing language while notifications are showing will not update notification #17190

Closed
ekager opened this issue Dec 22, 2020 · 4 comments
Closed

[Bug] Changing language while notifications are showing will not update notification #17190

ekager opened this issue Dec 22, 2020 · 4 comments
Assignees
@eliserichards
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Notifications 🌐 L10N Localization, translation, strings, ..
Milestone
89

Comments

@ekager
Copy link
Contributor

ekager commented Dec 22, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Enter Private Browsing Mode
  2. Open a tab
  3. Open device notifications and see PBM notification
  4. Go to settings and change the language

image

Expected behavior

Notification re-creates and reflects new language

Actual behavior

Notification does not recreate. Language updated only on app restart.

Device information

  • Android device: Android 11, Pixel 3
  • Fenix version: Nightly

┆Issue is synchronized with this Jira Task
@ekager ekager added 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Notifications labels Dec 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 22, 2020
@sflorean sflorean removed the needs:triage Issue needs triage label Dec 29, 2020
@eliserichards eliserichards added the 🌐 L10N Localization, translation, strings, .. label Jan 27, 2021
@eliserichards eliserichards self-assigned this Jan 29, 2021
@eliserichards
Copy link
Contributor

Expected flow (Google Chrome)

  1. Open Chrome
  2. Open a private browsing session, see the PBM notification in the device notifs
  3. Background Chrome
  4. Go to device settings, change language
  5. Foreground Chrome, see that the language of the notification changes once Chrome is brought back to the foreground

@Mugurell
Copy link
Contributor

@eliserichards I'm seeing this ticket in "Ready for engineering"
so with the current backlog running low I am wondering if you are actively working or planning to work on this or it can be picked up by others?

This was referenced Feb 22, 2021
Closed
Merged
rvandermeulen pushed a commit that referenced this issue Mar 23, 2021
@eliserichards @Amejia481
For #17190: notifications are updated when locale is changed (#18179)
559cf54 
* Add intent processor for locale changes

* Recreate notification and notify in the service

* Use locale use cases to update notification

* Use notification id instead of tag

* Add locale use cases and restore locale in application

* Send locale to service instead of string

* Controller tests for locale

* Update Android Components version to 74.0.20210323143308

Co-authored-by: Arturo Mejia <[email protected]>
Amejia481 pushed a commit that referenced this issue Mar 23, 2021
@eliserichards @Amejia481
For #17190: notifications are updated when locale is changed (#18179)
db6665f 
* Add intent processor for locale changes

* Recreate notification and notify in the service

* Use locale use cases to update notification

* Use notification id instead of tag

* Add locale use cases and restore locale in application

* Send locale to service instead of string

* Controller tests for locale

* Update Android Components version to 74.0.20210323143308

Co-authored-by: Arturo Mejia <[email protected]>

(cherry picked from commit 559cf54)
mergify bot pushed a commit that referenced this issue Mar 23, 2021
@eliserichards @mergify
For #17190: notifications are updated when locale is changed (#18179)
eec72dc 
* Add intent processor for locale changes

* Recreate notification and notify in the service

* Use locale use cases to update notification

* Use notification id instead of tag

* Add locale use cases and restore locale in application

* Send locale to service instead of string

* Controller tests for locale

* Update Android Components version to 74.0.20210323143308

Co-authored-by: Arturo Mejia <[email protected]>

(cherry picked from commit 559cf54)
@eliserichards
Copy link
Contributor

For QA

Fenix decides it's language in two ways: either following the device language, or choosing one from Fenix settings. When the user chooses a language in Fenix, we no longer care if the user changes their device language (we persist the language set in the app).

Steps to test this fix:

  1. Open Fenix
  2. Open a private tab(s), see the notification in the system notifications
  3. Go to Fenix app settings, select another language
  4. Look at the notifications and see the notification language has updated

@eliserichards eliserichards added the eng:qa:needed QA Needed label Mar 23, 2021
@sflorean
Copy link
Contributor

Verified as fixed on latest Nightly build with Pixel 3 (Android 11).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 24, 2021
@gabrielluong gabrielluong added this to the 89 milestone Mar 24, 2021
@mcarare mcarare mentioned this issue Mar 31, 2021
Closed
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@eliserichards @pkirakosyan
For mozilla-mobile#17190: notifications are updated when locale is ch…
d03d838 
…anged (mozilla-mobile#18179)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Notifications 🌐 L10N Localization, translation, strings, ..
Projects
None yet
Milestone
89
Development

No branches or pull requests
5 participants
@gabrielluong @Mugurell @ekager @eliserichards @sflorean