This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #8535, #7304: Prevent dispatching individual actions to restore tabs #8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
approved these changes
Oct 2, 2020
pocmo
approved these changes
Oct 2, 2020
|
@pocmo @jonalmeida I added a commit to here to introduce a state flag to indicate that restore is complete. Not sure if the name is ideal? We only need to set this to true once and for now applications should dispatch the action. Later, we can introduce a |
This was
linked to
issues
Oct 2, 2020
…ndividual actions to restore tabs Co-authored-by: Jonathan Almeida <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft to validate performance impact. Instead of dispatching individual actions to update the state of the restored tab we make sure that the initial state is correct, based on the Snapshot.
RestoreActionis already a "bulk action", but tabs didn't include the full initial state and subsequent actions were required, which is fixed here.