This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #696: browser-engine-system: Clear "X-Requested-With" header when loading URLs. #699
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
force-pushed
the
x-requested-with
branch
from
e1ef449
to
e09f177
Compare
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
============================================
+ Coverage 78.65% 78.66% +0.01%
Complexity 1125 1125
============================================
Files 158 158
Lines 4085 4087 +2
Branches 600 600
============================================
+ Hits 3213 3215 +2
Misses 578 578
Partials 294 294
Continue to review full report at Codecov.
|
csadilek
approved these changes
Sep 4, 2018
| @@ -29,12 +37,12 @@ class SystemEngineSession(private val defaultSettings: Settings? = null) : Engin | |||
| val internalView = currentView() | |||
|
|
|||
| if (internalView == null) { | |||
| // We can't load a URL without a WebView. So let's just remember the URL here until | |||
| // We can't load al URL without a WebView. So let's just remember the URL here until | |||
| @@ -13,6 +13,14 @@ import kotlinx.coroutines.experimental.launch | |||
| import mozilla.components.concept.engine.Settings | |||
| import mozilla.components.concept.engine.request.RequestInterceptor | |||
|
|
|||
| internal val additionalHeaders = HashMap<String, String>().apply { | |||
There was a problem hiding this comment.
Could use mutableMapOf/mapOf("X-Requested-With" to "")
There was a problem hiding this comment.
Yeah, that's nicer. I'll update :)
…ith" header when loading URLs.
pocmo
force-pushed
the
x-requested-with
branch
from
e09f177
to
91038db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another WebView thing.. :)
Closes #696