This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Move intent related code from browser-session to feature-intent. #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode from browser-session to feature-intent.
pocmo
changed the title
csadilek
approved these changes
Sep 3, 2019
|
bors r=csadilek |
Merge conflict (retrying...) |
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2019
4276: Add blog posting explaining browser-state plans. [ci skip] r=csadilek,Amejia481 a=pocmo I wanted to write this blog posting for quite a while. There's much more to say but this can be follow-up postings. :) 4281: Move intent related code from browser-session to feature-intent. r=csadilek a=pocmo In preparation for #4279 and #4257. :) 4294: Issue #4284: Add DownloadState to browser-state. r=csadilek a=pocmo First steps for #4284. State is not synchronized between `browser-state` and `browser-session` yet. I need to figure out how to deal with the `Consumable<Download>`in `Session`. We already did that when we prototyped this earlier this year. I think that's the reason we introduced `Consumable.onConsume`. Co-authored-by: Sebastian Kaspari <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #4279 and #4257. :)
Pull Request checklist
After merge