Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

TabThumbnailView should always scale to the entire width #7352

Closed
jonalmeida opened this issue Jun 12, 2020 · 0 comments · Fixed by #7356
Closed

TabThumbnailView should always scale to the entire width #7352

jonalmeida opened this issue Jun 12, 2020 · 0 comments · Fixed by #7356
Assignees
@jonalmeida
Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails
Milestone
46.0.0 🏄‍♂️

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jun 12, 2020 •
edited by data-sync-user
Loading

We should remove the conditional check for setFrame since it doesn't make sense when we don't have a drawable immediately when async loading.

This can lead to bugs like mozilla-mobile/fenix#11192

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails labels Jun 12, 2020
@jonalmeida jonalmeida self-assigned this Jun 12, 2020
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Jun 12, 2020
@jonalmeida
Close mozilla-mobile#7352: Always set scaleFactor on TabThumbnailView
b51edf6
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Jun 12, 2020
@jonalmeida
Close mozilla-mobile#7352: Always set scaleFactor on TabThumbnailView
eecfd92
@jonalmeida jonalmeida linked a pull request Jun 12, 2020 that will close this issue
Issue #7313: Use ThumbnailLoader for the TabViewHolder #7356
Merged
4 tasks
@bors bors bot closed this as completed in fc6a582 Jun 12, 2020
@jonalmeida jonalmeida added this to the 46.0.0 🏄‍♂️ milestone Jun 16, 2020
@jonalmeida jonalmeida mentioned this issue Jun 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs <thumbnails> Components: browser-thumbnails
Projects
None yet
Milestone
46.0.0 🏄‍♂️
Development

Successfully merging a pull request may close this issue.

Issue #7313: Use ThumbnailLoader for the TabViewHolder jonalmeida/android-components
1 participant
@jonalmeida