Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Extend RequestInterceptor to support error pages #718

Closed
pocmo opened this issue Sep 6, 2018 · 0 comments
Closed

Extend RequestInterceptor to support error pages #718

pocmo opened this issue Sep 6, 2018 · 0 comments
Assignees
@csadilek
Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🎭 Focus Requirements for Focus/Klar
Milestone
0.23 🗿

Comments

@pocmo
Copy link
Contributor

pocmo commented Sep 6, 2018 •
edited by data-sync-user
Loading

Either extend RequestInterceptor or add a new class in order to return customized content for error pages.

WebView

  • WebViewClient.onReceivedError( )
  • WebViewClient.onReceivedSslError()

GeckoView

  • GeckoSession.NavigationDelegate.onLoadError()

Follow-up

After that we should make sure that browser-errorpages works nicely with the new API.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🎭 Focus Requirements for Focus/Klar 📺 Fire TV labels Sep 6, 2018
@pocmo pocmo added this to the 0.23 🗿 milestone Sep 6, 2018
@pocmo pocmo mentioned this issue Sep 6, 2018
Closed
16 tasks
@pocmo pocmo mentioned this issue Sep 10, 2018
Closed
3 tasks
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Sep 12, 2018
@jonalmeida
Closes mozilla-mobile#718: Extend RequestInterceptor to support error…
bde12e2 
… pages
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Sep 12, 2018
@jonalmeida
Closes mozilla-mobile#718: Extend RequestInterceptor to support error…
bca04e5 
… pages
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Sep 13, 2018
@jonalmeida
Closes mozilla-mobile#718: Extend RequestInterceptor to support error…
fbb9074 
… pages
vladikoff pushed a commit to vladikoff/android-components that referenced this issue Sep 17, 2018
@jonalmeida @vladikoff
Closes mozilla-mobile#718: Extend RequestInterceptor to support error…
330f7d3 
… pages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🎭 Focus Requirements for Focus/Klar
Projects
None yet
Milestone
0.23 🗿
Development

No branches or pull requests
2 participants
@pocmo @csadilek