This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Track when a permission prompt is shown and what action user chooses #12345
Comments
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Jun 17, 2022
This will allow identifying with what permissions the user interacts.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Jun 17, 2022
… shown/allowed/denied
mergify bot
pushed a commit
that referenced
this issue
Jun 23, 2022
This will allow identifying with what permissions the user interacts.
jonalmeida
added a commit
to jonalmeida/android-components
that referenced
this issue
Aug 9, 2022
…r characters
To avoid matching against issues in other repositories, we can reduce
our matches to not include values if they are preceded by 1 or more
string/number/hypen/underscore values.
Tested using:
- a JS console:
```javascript
const issueRegExp = new RegExp("(?<![A-Za-z\\-\\_]+)#(\\d+)+", "g");
const numMatches = Array.from(issueRegExp[Symbol.matchAll]("mozilla-mobile#12345")).length
const numMatches2 = Array.from(issueRegExp[Symbol.matchAll](" mozilla-mobile#12345 ")).length
assert(numMatches == 0);
assert(numMatches2 == 1);
```
- regex tester: https://regexr.com/6rg2v
4 tasks
mergify bot
pushed a commit
that referenced
this issue
Oct 11, 2022
To avoid matching against issues in other repositories, we can reduce
our matches to not include values if they are preceded by 1 or more
string/number/hypen/underscore values.
Tested using:
- a JS console:
```javascript
const issueRegExp = new RegExp("(?<![A-Za-z\\-\\_]+)#(\\d+)+", "g");
const numMatches = Array.from(issueRegExp[Symbol.matchAll]("#12345")).length
const numMatches2 = Array.from(issueRegExp[Symbol.matchAll](" #12345 ")).length
assert(numMatches == 0);
assert(numMatches2 == 1);
```
- regex tester: https://regexr.com/6rg2v
JohanLorenzo
pushed a commit
to mozilla-mobile/firefox-android
that referenced
this issue
Oct 13, 2022
…tch issue ID if preceded by other characters
To avoid matching against issues in other repositories, we can reduce
our matches to not include values if they are preceded by 1 or more
string/number/hypen/underscore values.
Tested using:
- a JS console:
```javascript
const issueRegExp = new RegExp("(?<![A-Za-z\\-\\_]+)#(\\d+)+", "g");
const numMatches = Array.from(issueRegExp[Symbol.matchAll]("https://github.com/mozilla-mobile/android-components/issues/12345")).length
const numMatches2 = Array.from(issueRegExp[Symbol.matchAll](" mozilla-mobile/android-components#12345 ")).length
assert(numMatches == 0);
assert(numMatches2 == 1);
```
- regex tester: https://regexr.com/6rg2v
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For https://mozilla-hub.atlassian.net/browse/FNXV2-20626 we also need to track when a permission prompt is shown and what action user chooses.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: