This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Introduce GeckoStorageDelegateWrapper to replace GeckoLoginDelegateWrapper #10140

Closed

gabrielluong opened this issue Apr 22, 2021 · 0 comments · Fixed by #10146

Assignees

Labels

Milestone

Member

gabrielluong commented Apr 22, 2021 •

edited by data-sync-user

Loading

Currently, GeckoLoginDelegateWrapper relies on Autocomplete.LoginStorageDelegate, which is deprecated in #10093. We want to introduce a more generic GeckoStorageDelegateWrapper which will use the new GV API Autocomplete.StorageDelegate, but also provide support for fetching credit card so that it can be autocompleted.

┆Issue is synchronized with this Jira Task

The text was updated successfully, but these errors were encountered:

gabrielluong self-assigned this

gabrielluong added <autofill> cc-autofill E2 labels

gabrielluong added this to the 90.0.0 milestone

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

20ec8ba

…functions into ext/Autofill.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Autofill.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

f456732

…eWrapper as GeckoStorageDelegateWrapper

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegateWrapper` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

c774c7f

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong mentioned this issue

Issue #10140: Introduce GeckoStorageDelegateWrapper to replace GeckoLoginDelegateWrapper #10146

Merged

4 tasks

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

2f0f845

…functions into ext/Autofill.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Autofill.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

62acdcb

…eWrapper as GeckoStorageDelegateWrapper

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegateWrapper` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

a236c11

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

f6201d0

…functions into ext/Autofill.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Autofill.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

2d6e344

…eWrapper as GeckoStorageDelegateWrapper

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegateWrapper` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

a942ee3

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

0ac7ec8

…eWrapper as GeckoStorageDelegateWrapper

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegateWrapper` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

2b66952

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

2a5709a

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

75ca0ef

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GV `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements `onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

d810dc9

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

35048da

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

5d808a8

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

b1ee74e

…eWrapper as GeckoStorageDelegateWrapper

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegateWrapper` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

8d9a131

…torageDelegate interface in GeckoStorageDelegateWrapper

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegateWrapper
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

1f7eba5

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

234dcee

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

68b2185

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

3b52fdb

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

90ef4bf

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

76b94ad

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 4: Add tests for GeckoAutocompleteS…

5613c8d

…torageDelegate

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

1f08285

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

c1f7a3b

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

48e1a71

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 4: Add tests for GeckoAutocompleteS…

6329d18

…torageDelegate

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 4: Add tests for GeckoAutocompleteS…

9aa32d5

…torageDelegate

gabrielluong mentioned this issue

Add tests for GeckoAutocompleteStorageDelegate #10214

Closed

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

7cce63c

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

895034f

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

007ef12

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

4c04d08

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

c937277

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

f0ecdee

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 1: Refactor autocomplete extension …

19c9a9b

…functions into ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 2: Make a copy of GeckoLoginDelegat…

fdd6d22

…eWrapper as GeckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

gabrielluong added a commit to gabrielluong/android-components that referenced this issue


          Issue mozilla-mobile#10140 - Part 3: Implement the new Autocomplete.S…

63a5100

…torageDelegate interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

mergify bot closed this as completed in #10146

mergify bot pushed a commit that referenced this issue


          Issue #10140 - Part 1: Refactor autocomplete extension functions into…

db44646

… ext/Login.kt

- Moves `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()` extension functions
into `ext/Login.kt`
- Remove duplicates of `Autocomplete.LoginEntry.toLogin()` and `Login.toLoginEntry()`.

mergify bot pushed a commit that referenced this issue


          Issue #10140 - Part 2: Make a copy of GeckoLoginDelegateWrapper as Ge…

…ckoAutocompleteStorageDelegate

We make a copy of GeckoLoginDelegateWrapper to not break the deprecated usage of `Autocomplete.LoginStorageDelegate`
until we are ready to replace with `GeckoStorageDelegate` which will use the new GV API `Autocomplete.StorageDelegate`.

mergify bot pushed a commit that referenced this issue


          Issue #10140 - Part 3: Implement the new Autocomplete.StorageDelegate…

1953a94

… interface in GeckoAutocompleteStorageDelegate

- Uses the new GeckoView's `Autocomplete.StorageDelegate` interface in GeckoStorageDelegate
- Implements GeckoView's `Autocomplete.StorageDelegate.onCreditCardFetch`

Archaeopteryx mentioned this issue

Intermittent services-sync-autofill - mozilla.components.service.sync.autofill.AutofillCreditCardsAddressesStorageTest - delete credit card #10228

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.