feat(gateway): add gateway provider - #587
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 40 files with indirect coverage changes 🚀 New features to boost your workflow:
|
daavoo
reviewed
Oct 29, 2025
daavoo
reviewed
Oct 29, 2025
njbrake
commented
Oct 29, 2025
daavoo
previously approved these changes
Oct 30, 2025
daavoo
left a comment
daavoo
left a comment
Contributor
There was a problem hiding this comment.
Not critical, but some simple unit tests would be nice to have
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Contributor
Author
Good point. I'll add a few unit tests and then I'll merge it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(untested) Eventually I think we would be able to add it to the integration test suite, once the gateway is a public image so that we can easily run it in a github action without needing to configure authentication etc.
PR Type
🆕 New Feature ## Relevant issuesChecklist