Skip to content

fix: threading approach in run_async_in_sync didn't wait for all tasks to complete - #487

Merged
njbrake merged 4 commits into
mainfrom
477-in_thread_exception
Sep 20, 2025
Merged

njbrake merged 4 commits into
mainfrom
477-in_thread_exception

Conversation

@njbrake

@njbrake njbrake commented Sep 20, 2025 •

Copy link
Copy Markdown
Contributor

Description

Fix the error when running tasks in threads

PR Type

🐛 Bug Fix ## Relevant issues

Checklist

  • I have added unit tests that prove my fix/feature works
  • New and existing tests pass locally
  • Documentation was updated where necessary
  • I have read and followed the contribution guidelines```

@codecov

codecov Bot commented Sep 20, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/any_llm/utils/aio.py 46.66% 7 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/any_llm/utils/aio.py 54.16% <46.66%> (+7.10%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njbrake njbrake changed the title expose error fix: threading approach in run_async_in_sync didn't wait for all tasks to complete Sep 20, 2025
@njbrake
njbrake merged commit e9dc304 into main Sep 20, 2025
10 of 11 checks passed
@njbrake
njbrake deleted the 477-in_thread_exception branch September 20, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What happens when an exception is thrown inside the sync to Async wrapper

1 participant