Repository navigation
fix(gemini): carry the text-part thought_signature across turns #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
njbrake
merged 10 commits into
mozilla-ai:main
from
JamMaster1999:fix/gemini-text-thought-signature
Aug 19, 2026
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
96457c3
fix(gemini): carry the text-part thought_signature across turns
JamMaster1999 7d1fa82
fix(gemini): keep the text-part signature variable apart from the too…
JamMaster1999 f81892a
tests(gemini): pin the tool-call signature path on base and match nei…
JamMaster1999 aaacf8b
tests(gemini): pin message extra_content through _convert_completion_…
JamMaster1999 34ae20e
docs: docstrings on the touched gemini converter and test
JamMaster1999 b6ef62c
fix(gemini): ignore a malformed extra_content on the text replay path
njbrake 8d69578
fix(tests): unbreak mypy on the openai httpx2 response type
njbrake 77e0fd9
fix(gemini): reject an undecodable thought_signature with InvalidRequ…
njbrake f401010
revert: drop the local httpx2 mypy workaround, main fixed it upstream
njbrake 60cb7a1
Merge remote-tracking branch 'origin/main' into fix/gemini-text-thoug…
njbrake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Add coverage for the final response conversion.
The new tests validate
_convert_response_to_response_dict, but notGoogleProvider._convert_completion_response. Add a test that passes messageextra_contentinto this method and assertschoices[0].message.extra_content. This verifies the publicChatCompletionoutput preserves the signature.As per coding guidelines, “Add or adjust tests for every change, covering happy paths and error cases.”
🤖 Prompt for AI Agents
Source: Coding guidelines