-
Notifications
You must be signed in to change notification settings - Fork 228
fix(gemini): accumulate non-streaming reasoning parts #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
njbrake
merged 4 commits into
mozilla-ai:main
from
mikemikimike:codex/fix-1277-gemini-thought-accumulation
Aug 13, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8149e51
fix(gemini): accumulate non-streaming reasoning parts
mikemikimike fdc5a60
fix(gemini): keep reasoning None when a thought part carries no text
njbrake 5abf339
fix(gemini): accumulate non-streaming text parts
njbrake d88556f
tests(gemini): cover parts carrying neither text nor a function call
njbrake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Prefer direct access for the typed
Part.textfield.partcomes fromtypes.GenerateContentResponseand the streaming converter already accessespart.textdirectly. Usepart.texthere unless this path intentionally accepts dynamic or untyped objects.As per coding guidelines, prefer direct typed attribute access and reserve
getattrfor genuinely dynamic or untyped attributes.🤖 Prompt for AI Agents
Source: Coding guidelines