Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add next plugin that deals with webpack workarounds #4

Merged
merged 2 commits into from
Nov 22, 2019
Merged

feat: add next plugin that deals with webpack workarounds #4

merged 2 commits into from
Nov 22, 2019

Commits on Nov 22, 2019

  1. feat: add next plugin that deals with webpack workarounds 

    The canvas package, which is a dependency of jsdom, has a native binding which causes the following error during Next.js build process: "Module did not self-register".
We circuvent that by using a null-loader.
See vercel/next.js#7894

The ws package, which is also a dependency of jsdom, tries to optionally load some dependencies.
This produces a warning in webpack that we want to avoid.
We circuvent that by adding them to externals.
    @satazor
    satazor committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    031a1af View commit details
    Browse the repository at this point in the history

  2. chore: update README.md 

    Co-Authored-By: Ivo Lima Silva <[email protected]>
    @satazor @ivolimasilva
    satazor and ivolimasilva committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    8f58c3d View commit details
    Browse the repository at this point in the history