Skip to content

Conversation

@rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Mar 4, 2022

  • Fix Regression with prunning #337
    If two Connect stages are sequenced, both sides can become ARMED.
    However, that means that the wave of PRUNED status updates, shouldn't overwrite a present ARMED state.
  • Added a corresponding unit test
  • Improved debug output / comments

@rhaschke rhaschke mentioned this pull request Mar 4, 2022
rhaschke added 2 commits March 4, 2022 15:01
If two Connect stages are sequenced, both sides can become ARMED.
However, that means that the wave of PRUNED status updates, shouldn't
overwrite a present ARMED state.
Added unit test.
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #340 (096c671) into master (ca38d11) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   54.59%   54.55%   -0.03%     
==========================================
  Files         102      102              
  Lines        7832     7843      +11     
==========================================
+ Hits         4275     4278       +3     
- Misses       3557     3565       +8     
Impacted Files Coverage Δ
core/include/moveit/task_constructor/storage.h 89.70% <ø> (ø)
core/src/stage.cpp 82.93% <ø> (ø)
core/src/storage.cpp 81.17% <40.00%> (-3.86%) ⬇️
core/src/stages/fixed_state.cpp 95.46% <0.00%> (-4.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca38d11...096c671. Read the comment docs.

@captain-yoshi
Copy link
Contributor

This fixes the regression on my end !

@rhaschke rhaschke merged commit d2918f1 into moveit:master May 8, 2022
@rhaschke rhaschke deleted the fix-#337 branch May 8, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with prunning

2 participants