Skip to content

Conversation

@v4hn
Copy link
Contributor

@v4hn v4hn commented Dec 14, 2021

direction was interpreted relative to the link even when an ik_frame was specified.

Solves #318 .

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #320 (6f61d04) into master (b4a9e20) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Current head 6f61d04 differs from pull request most recent head 84f96ec. Consider uploading reports for the commit 84f96ec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   53.00%   53.29%   +0.30%     
==========================================
  Files         102      102              
  Lines        7599     7602       +3     
==========================================
+ Hits         4027     4051      +24     
+ Misses       3572     3551      -21     
Impacted Files Coverage Δ
core/src/stages/move_relative.cpp 80.98% <100.00%> (+11.42%) ⬆️
...ude/moveit/task_constructor/stages/move_relative.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a9e20...84f96ec. Read the comment docs.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Michael. Please have a look at my simplify commit and finally merge if OK.

Copy link

@jliukkonen jliukkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple small nitpicks. Thanks for the fix!

@v4hn v4hn force-pushed the pr-master-fix-move-rel-ikframe branch from 6f61d04 to 84f96ec Compare December 20, 2021 09:20
@v4hn v4hn merged commit f9c0a89 into moveit:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants