generic improvements #295
Merged
generic improvements #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed states are *not* disabled, they just failed connecting (for now).
These can facilitate debugging a lot for little overhead.
This could have been done already back when `runCompute` was introduced. Wrapping the calls in try/catch comes from the previous implementation directly calling `compute()`.
This makes the semantics much clearer as states can only be disabled by pruning.
- build pick_place_task as proper library as people (e.g. moveit_benchmark_suite) reuse it
before anyone starts copying from here...
… of a partial solution In all other cases internalToExternalMap().find(s) will fail anyway.
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 51.43% 51.51% +0.09%
==========================================
Files 101 101
Lines 7133 7129 -4
==========================================
+ Hits 3668 3672 +4
+ Misses 3465 3457 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out generic improvements from proper Fallbacks support, as per
#287 (comment)