new set of fallback tests #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work, but will require more changes.
The current implementation will not fall back for each state independently, but is meant to stay with the first child producing a solution. For propagators, this is problematic though as the picked child depends on the (arbitrary) first received state. Instead, fallbacks should pass each state to each child separately until one produces a solution for it (or all are exhausted).
They will be enabled when the corresponding functionality is merged.
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 51.43% 51.43%
=======================================
Files 101 101
Lines 7133 7133
=======================================
Hits 3668 3668
Misses 3465 3465 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of them currently disabled as proposed in
#287 (comment)