Skip to content

Conversation

@vatanaksoytezer
Copy link

Most of the tutorials depends on demo.launch.py of panda_moveit_config. This PR adds this file along with rviz2 configs, so it can be used by tutorials.

Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vatanaksoytezer why did the rviz configs change? Are the changes compatible with ROS1 & 2?

@vatanaksoytezer
Copy link
Author

@vatanaksoytezer why did the rviz configs change? Are the changes compatible with ROS1 & 2?

rviz configurations are not compatible between ROS1 and ROS2 so I had to make a new ROS2 config.

@MarqRazz
Copy link
Contributor

MarqRazz commented May 5, 2021

If that is the case should we delete demo.launch? I know the rest of the launch files are not working but we should probably delete the ones that have been converted.

@vatanaksoytezer
Copy link
Author

If that is the case should we delete demo.launch? I know the rest of the launch files are not working but we should probably delete the ones that have been converted.

I was questioning that myself as well. I just left it as a reference but since it is converted it makes sense to delete it. I'll delete it.

@henningkayser henningkayser merged commit 34367e6 into moveit:ros2 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants