Skip to content

Conversation

@tylerjw
Copy link
Member

@tylerjw tylerjw commented Jul 29, 2021

Description

rolling-testing does not seem to be fixed yet (one week after it was broken) even with all the work that @jspricke did helping osrf figure out what is wrong with it. I propose we disable testing on it until the core packages are more stable on it. The point of rolling-testing is to get API breaking changes sooner so we can adapt to them, instead what we've gotten is buildfarm breaking changes and there is no way for us to adapt other than stop testing on rolling-testing.

osrf/infrastructure#5

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #576 (9cd7e3f) into main (f2abc40) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   46.78%   46.79%   +0.01%     
==========================================
  Files         185      185              
  Lines       19689    19689              
==========================================
+ Hits         9210     9211       +1     
+ Misses      10479    10478       -1     
Impacted Files Coverage Δ
...e/collision_detection_fcl/src/collision_common.cpp 74.40% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2abc40...9cd7e3f. Read the comment docs.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue to enable this back once it is fixed?

@tylerjw tylerjw merged commit 8112941 into moveit:main Jul 29, 2021
@tylerjw tylerjw deleted the disable-rolling-testing branch July 29, 2021 17:31
@lilustga lilustga mentioned this pull request Jul 29, 2021
6 tasks
christianlandgraf pushed a commit to christianlandgraf/moveit2 that referenced this pull request Aug 12, 2021
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Aug 27, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants