-
Notifications
You must be signed in to change notification settings - Fork 692
Update repos files for CI #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The basic idea here is that so long as the released versions of our upstream repos doesn't have a breaking change we depend on we can install them via the debains in our tests. As soon as someone makes a change where they need the repos file and we haven't yet released they can comment them back out until those are synced into the buildfarm. Currently the only upstream repos we need to build are these: rolling:
|
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 46.80% 46.79% -0.00%
==========================================
Files 185 185
Lines 19689 19693 +4
==========================================
+ Hits 9213 9214 +1
- Misses 10476 10479 +3
Continue to review full report at Codecov.
|
vatanaksoytezer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we don't forget to ask people to uncomment this back when they want to merge a PR that is depending on our upstreams, this is good, adds more reliablity to binaries and increases the CI time.
|
@henningkayser could you give this a review? Do you like the general idea of this? |
So long as the released versions of our upstream repos don't have a breaking change we just depend on the debains in our tests. As soon as someone makes a change where they need the repos file, they can comment them back out until upstream changes are synced into the buildfarm.
So long as the released versions of our upstream repos don't have a breaking change we just depend on the debains in our tests. As soon as someone makes a change where they need the repos file, they can comment them back out until upstream changes are synced into the buildfarm.
* Add comment about the importance of AsyncSpinner
Description
This updates the repos files and CI jobs to reflect what is released and needed for doing CI jobs.