Skip to content

Conversation

@tylerjw
Copy link
Member

@tylerjw tylerjw commented Jul 22, 2021

Description

This updates the repos files and CI jobs to reflect what is released and needed for doing CI jobs.

@tylerjw tylerjw requested a review from vatanaksoytezer July 22, 2021 21:17
@tylerjw
Copy link
Member Author

tylerjw commented Jul 22, 2021

The basic idea here is that so long as the released versions of our upstream repos doesn't have a breaking change we depend on we can install them via the debains in our tests. As soon as someone makes a change where they need the repos file and we haven't yet released they can comment them back out until those are synced into the buildfarm. Currently the only upstream repos we need to build are these:

rolling:

  • warehouse_ros (waiting on sync)
  • warehouse_ros_mongo (waiting on sync)
  • geometric_shapes (broken on rolling, needs PR to fix it)
    galactic: none
    foxy: none

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #565 (1b2bf0a) into main (8112941) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   46.80%   46.79%   -0.00%     
==========================================
  Files         185      185              
  Lines       19689    19693       +4     
==========================================
+ Hits         9213     9214       +1     
- Misses      10476    10479       +3     
Impacted Files Coverage Δ
...ene/include/moveit/planning_scene/planning_scene.h 53.45% <ø> (ø)
...bot_model/include/moveit/robot_model/joint_model.h 82.86% <ø> (ø)
...it/planning_scene_monitor/planning_scene_monitor.h 0.00% <ø> (ø)
moveit_ros/planning/rdf_loader/src/rdf_loader.cpp 21.65% <ø> (ø)
...n/allvalid/collision_detector_allocator_allvalid.h 100.00% <100.00%> (ø)
...ction_bullet/collision_detector_allocator_bullet.h 100.00% <100.00%> (ø)
...n_detection_fcl/collision_detector_allocator_fcl.h 100.00% <100.00%> (ø)
...e/include/moveit/kinematics_base/kinematics_base.h 46.67% <100.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 74.72% <0.00%> (-1.13%) ⬇️
moveit_core/robot_model/src/aabb.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a4539...1b2bf0a. Read the comment docs.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't forget to ask people to uncomment this back when they want to merge a PR that is depending on our upstreams, this is good, adds more reliablity to binaries and increases the CI time.

@tylerjw
Copy link
Member Author

tylerjw commented Jul 28, 2021

@henningkayser could you give this a review? Do you like the general idea of this?

This was referenced Jul 30, 2021
@vatanaksoytezer vatanaksoytezer mentioned this pull request Jul 30, 2021
@henningkayser henningkayser merged commit d903614 into moveit:main Jul 30, 2021
christianlandgraf pushed a commit to christianlandgraf/moveit2 that referenced this pull request Aug 12, 2021
So long as the released versions of our upstream repos don't have a breaking change we just depend on the debains in our tests. As soon as someone makes a change where they need the repos file, they can comment them back out until upstream changes are synced into the buildfarm.
tylerjw added a commit to tylerjw/moveit2 that referenced this pull request Aug 27, 2021
So long as the released versions of our upstream repos don't have a breaking change we just depend on the debains in our tests. As soon as someone makes a change where they need the repos file, they can comment them back out until upstream changes are synced into the buildfarm.
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
* Add comment about the importance of AsyncSpinner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants