Update launch files to use ros2 control spawner#405
Merged
tylerjw merged 5 commits intomoveit:mainfrom Apr 1, 2021
Merged
Conversation
JafarAbdi
force-pushed
the
pr-use_ros2_control_spwaner
branch
from
25458fd to
3119e35
Compare
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 53.03% 53.05% +0.03%
==========================================
Files 212 212
Lines 22612 22612
==========================================
+ Hits 11990 11995 +5
+ Misses 10622 10617 -5
Continue to review full report at Codecov.
|
MarqRazz
approved these changes
Apr 1, 2021
Contributor
MarqRazz
left a comment
MarqRazz
left a comment
There was a problem hiding this comment.
Great work @JafarAbdi! I tested a few of the demo nodes on my PC and they work great. Just let me know if you want me to create the PR to fix the run_move_group cmake file.
tylerjw
approved these changes
Apr 1, 2021
Member
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
This seems to fix the flaky-ness of the tests. Thank you 🥇
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
* Improve wording in Getting Started and other tutorials * Fixup * Improve README * Address PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: #399
Use the newly merged spawner ros-controls/ros2_control#310 to load the controllers
Checklist