MTC compatiblity fixes #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjw
approved these changes
Jan 5, 2021
Member
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
Just a couple small questions. Overall looks good.
moveit_core/utils/include/moveit/utils/robot_model_test_utils.h
Outdated
Show resolved
Hide resolved
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 157 157
Lines 14843 14843
=======================================
Hits 7124 7124
Misses 7719 7719
Continue to review full report at Codecov.
|
Member
|
This PR includes cherry-picked commits from Moveit 1 master, right? I think we should only apply your added fixes and run another sync to add the remaining changes. |
...controller_manager/include/moveit_simple_controller_manager/action_based_controller_handle.h
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/planning_scene_interface/src/planning_scene_interface.cpp
Outdated
Show resolved
Hide resolved
… duration to seconds
JafarAbdi
force-pushed
the
pr-mtc_fixes
branch
from
3caf2ef to
a74262b
Compare
moveit_ros/planning_interface/planning_scene_interface/src/planning_scene_interface.cpp
Outdated
Show resolved
Hide resolved
henningkayser
approved these changes
Jan 8, 2021
henningkayser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are some fixes for bugs I encountered while porting MTC
+ backported the first two commitsChecklist