Skip to content

Use find_package for fcl#2399

Merged
tylerjw merged 1 commit intomainfrom
find_package_fcl
Sep 29, 2023
Merged

Use find_package for fcl#2399
tylerjw merged 1 commit intomainfrom
find_package_fcl

Conversation

@tylerjw
Copy link
Member

@tylerjw tylerjw commented Sep 29, 2023

Description

The version of fcl we use has a find module. We should just use it.

See #2391

@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9654bc1) 50.85% compared to head (38348d2) 50.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
- Coverage   50.85%   50.36%   -0.49%     
==========================================
  Files         386      385       -1     
  Lines       31943    31772     -171     
==========================================
- Hits        16242    15998     -244     
- Misses      15701    15774      +73     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylerjw tylerjw merged commit 498a9f3 into main Sep 29, 2023
@tylerjw tylerjw deleted the find_package_fcl branch September 29, 2023 22:06
mergify bot pushed a commit that referenced this pull request Sep 29, 2023
(cherry picked from commit 498a9f3)

# Conflicts:
#	moveit_core/CMakeLists.txt
sjahr pushed a commit that referenced this pull request Oct 3, 2023
* Use find_package for fcl (#2399)

(cherry picked from commit 498a9f3)

# Conflicts:
#	moveit_core/CMakeLists.txt

* Unify humble moveit_core CMake with main

---------

Co-authored-by: Tyler Weaver <tyler@picknik.ai>
Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
JeisonUR added a commit to Unlimited-Robotics/moveit2 that referenced this pull request Dec 29, 2023
traversaro added a commit to sonelu/ros-humble that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Mergify label that triggers a PR backport to Humble

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants