Remove no longer needed pedantic option overrides#1397
Merged
vatanaksoytezer merged 1 commit intomoveit:mainfrom Jun 28, 2022
Merged
Remove no longer needed pedantic option overrides#1397vatanaksoytezer merged 1 commit intomoveit:mainfrom
vatanaksoytezer merged 1 commit intomoveit:mainfrom
Conversation
nbbrooks
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 61.53% 61.54% +0.01%
==========================================
Files 274 274
Lines 24977 24977
==========================================
+ Hits 15368 15370 +2
+ Misses 9609 9607 -2
Continue to review full report at Codecov.
|
jspricke
approved these changes
Jun 27, 2022
vatanaksoytezer
approved these changes
Jun 27, 2022
tylerjw
force-pushed
the
remove-pedantic-option-overrides
branch
from
a898c3b to
cb546c7
Compare
tylerjw
approved these changes
Jun 28, 2022
…p_monitor package - The cited Octomap issue moveit#275 "Fix -Wpedantic warnings" has been merged, so we should no longer disable this option OctoMap/octomap#275 Remove unnecessary redefinition of pedantic option in moveit_ros_perception package
vatanaksoytezer
force-pushed
the
remove-pedantic-option-overrides
branch
from
cb546c7 to
185c8aa
Compare
peterdavidfagan
pushed a commit
to peterdavidfagan/moveit2
that referenced
this pull request
Jul 14, 2022
…p_monitor package (moveit#1397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove no longer needed no-pedantic option in moveit_ros_occupancy_map_monitor package
Remove unnecessary redefinition of pedantic option in moveit_ros_perception package
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist