chore(ci): match Ember Data version in LTS tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
force-pushed
the
use-lts-ember-data
branch
4 times, most recently
from
9a3eafb
to
114fd56
Compare
alexlafroscia
force-pushed
the
use-lts-ember-data
branch
2 times, most recently
from
604bc78
to
5f4bd6f
Compare
alexlafroscia
force-pushed
the
use-lts-ember-data
branch
from
5f4bd6f
to
e1d1e72
Compare
spencer516
approved these changes
Mar 20, 2020
|
Huh, turns out that this was the underlying issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.12 tests failed in #4 so I want to land this as a separate PR to establish a baseline that the current work on
masteractually does work in Ember 3.12.It should, since the add-on seems to work in our own Ember app that uses Ember 3.12.