Don't use window object

[kkaefer]

The window object doesn't exist in all JavaScript contexts, e.g. Web workers.

[mourner]

self is not a part of any specification, so in theory it can break in some browsers... Maybe lets use this?

[kkaefer]

this is not a globally defined variable.

[mourner]

But this should work in the top context, so many people do something like this:

(function (window) {
})(this);

I remember there were some issues with this approach too (when including Leaflet in browserify or something), @tmcw, comments?

[tmcw]

I usually rely on umd template to do the right thing and it does.

[patrickarlt]

We are using an adapted UMD template in Terraformer to make sure thing work in both node and browser environment.

This seems to work pretty well, here is the code...

(function (root, factory) {

  // Node.
  if(typeof module === 'object' && typeof module.exports === 'object') {
    exports = module.exports = factory();
  }

  // Browser Global.
  if(typeof window === "object") {
    root.Terraformer = factory();
  }

}(this, function(){

  //export stuff

  return exports;
}));

[mourner]

OK, found the Leaflet commit by @jfirebaugh Leaflet/Leaflet@e699894
It seems that in this case it's OK to pass this, as there are no window references except for exporting, which makes it compatible with browserify even without shimming. Right?

[jfirebaugh]

Yes, IIRC the leaflet change was necessary because it wanted to access actual window properties, not just attach exported properties to it.

[kkaefer]

this is not defined in a web worker global context.

[mourner]

Wow, I thought it was defined... Thanks Konstantin. Added export through self.
Not sure why there's a "global" export in the UMD template mentioned by @tmcw, seems not necessary.

[mourner]

BTW, regarding the export through global — the umd guys admitted that it's useless. ForbesLindesay/umd@4464d83