Fix loop condition in _allDistMargin #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes a bug in
_allDistMargin
. In the existing code, compare the loop condition forleftBBox
with the loop condition forrightBBox
:The code for
rightBBox
completes more iterations. I think the code should be symmetrical with both loops completing the same number of iterations. I think the attached patch fixes this by making therightBBox
loop match theleftBBox
loop.