-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging branch dev
into main; BanditPAM v2.0.0
release
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some more logging code
…ecute but several fail
… tests more stringent
…ependences in github actions
…n ones to lowercase_with_underscores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BanditPAM
v2.0.0
PR. Contains many changes:Organization and Functionality:
km
for better encapsulation (Fixes Make akmedoids
namespace for encapsulation #135)batchSize
tomin(dataset_size, 100)
(Fixes Need to setbatch_size
tomin(N, 100)
in case dataset has <100 points #158)int
s for the medoid indices instead offloat
s, including a list of a singleint
ifk=1
(FixesKMedoids.medoids
should beint
s, notfloat
s #152).cpp
file to appear in the same order they appear in the corresponding.hpp
setup.py
is now encapsulated (Fixes Encapsulate code insetup.py
#131)setup.py
(Fixesinstall_check_mac
should check for recent version of llvm #79)Tests:
Style:
camelCase
for C++ variables (Fixes Rename variables fromlower_case_with_underscores
tocamelCase
#140)const
qualifiers have been added where possibleDocumentation:
README
with links to the ReadTheDocs and SAIL blog post.cpp
files, moved all docstrings to the.hpp
files, updated the docstrings, and added the necessary@throws
and@returns
(Fixes Duplicate docstrings in headers and .cpp files? #127)