-
Notifications
You must be signed in to change notification settings - Fork 214
feat: add whisper.cpp server to cuda and musa containers #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rare-magma
wants to merge
5
commits into
mostlygeek:main
Choose a base branch
from
rare-magma:whisper-cpp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c54cf10
feat: add whisper.cpp server to docker images
rare-magma d986567
feat: fix path
rare-magma 61d3b2d
Update Docker install instructions in README
rare-magma c50fe0b
feat: add vulkan
rare-magma e4abc4a
Merge branch 'main' into whisper-cpp
rare-magma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ARG WH_IMAGE=ghcr.io/ggml-org/whisper.cpp | ||
| ARG WH_TAG=main-cuda | ||
| ARG BASE=llama-swap:latest | ||
|
|
||
| FROM ${WH_IMAGE}:${WH_TAG} AS ws-source | ||
| FROM ${BASE} | ||
|
|
||
| ARG UID=10001 | ||
| ARG GID=10001 | ||
|
|
||
| COPY --from=ws-source --chown=${UID}:${GID} /app/build/bin/whisper-server /app/whisper-server | ||
| COPY --from=ws-source --chown=${UID}:${GID} /app/build/src/*.so* /app/ | ||
|
|
||
| WORKDIR /app | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mostlygeek if the ggml library version diverges between llama-server and whisper-server then the whisper-server might fail as it was built with a different shared library. In order to mitigate this problem the whisper-server binary would have to be compiled with statically linked libraries. sd-server doesn't have that problem because it is built with statically linked libs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates some risk where whisper stops working with the llama-swap:cuda and musa containers. Ideally, in the container build step a statically compiled whisper is built and copied in. I attempted that before and found that it was not trivial to do.