Add path filters to CI workflows and create UI test workflow#501
Add path filters to CI workflows and create UI test workflow#501mostlygeek merged 3 commits intomainfrom
Conversation
WalkthroughAdds path-based filters to Linux and Windows Go CI workflows, introduces a new "UI Tests" workflow for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add ui-tests.yml workflow to run svelte type checking and vitest on push/PR to main when ui-svelte/ files change. - Add path filters to go-ci.yml and go-ci-windows.yml to skip Go tests when only non-backend files change - Filter on **/*.go, go.mod, go.sum, and Makefile https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
63cc616 to
a9dbce7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/ui-tests.yml:
- Around line 26-31: The workflow is using Node.js 23 which is end-of-life; edit
the GitHub Actions job that calls actions/setup-node@v4 and change the
node-version value from '23' to a supported release (preferably '24') so CI uses
Node.js 24; ensure the node-version: '23' line in the UI tests step is updated
to node-version: '24' (no other changes required).
🧹 Nitpick comments (1)
.github/workflows/go-ci-windows.yml (1)
8-13: Consider including workflow file changes in path filters.Changes to
.github/workflows/go-ci-windows.ymlitself won't trigger this workflow. If workflow logic changes, you'd need to manually trigger viaworkflow_dispatchto verify the changes work correctly.Consider adding the workflow file to the paths:
paths: - '**/*.go' - '!cmd/**' - 'go.mod' - 'go.sum' - 'Makefile' + - '.github/workflows/go-ci-windows.yml'
Remove unused `generatedText` state and `clearAudio` function that caused svelte-check errors. https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
Node 23 is end-of-life; bump to 24 in ui-tests.yml and release.yml. https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
…eek#501) * .github/workflows: add UI tests and path-filter Go CI Add ui-tests.yml workflow to run svelte type checking and vitest on push/PR to main when ui-svelte/ files change. - Add path filters to go-ci.yml and go-ci-windows.yml to skip Go tests when only non-backend files change - Filter on **/*.go, go.mod, go.sum, and Makefile https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7 * ui-svelte: remove unused declarations in SpeechInterface Remove unused `generatedText` state and `clearAudio` function that caused svelte-check errors. https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7 * .github/workflows: update Node.js to v24 Node 23 is end-of-life; bump to 24 in ui-tests.yml and release.yml. https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7 --------- Co-authored-by: Claude <noreply@anthropic.com>
Summary
This PR optimizes CI/CD workflows by adding path-based filters to reduce unnecessary workflow runs and introduces a new dedicated workflow for UI testing.
Key Changes
Go CI Workflows: Added path filters to
go-ci.ymlandgo-ci-windows.ymlto only trigger on changes to:**/*.go)go.mod,go.sum)Makefile)cmd/**directoryNew UI Test Workflow: Created
ui-tests.ymlworkflow that:ui-svelte/**directory onlynpm run check)npm test)ubuntu-latestrunnerBenefits
https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
Summary by CodeRabbit
Chores
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.