Skip to content

Add path filters to CI workflows and create UI test workflow#501

Merged
mostlygeek merged 3 commits intomainfrom
claude/add-ui-tests-github-action-yVjcH
Feb 1, 2026
Merged

Add path filters to CI workflows and create UI test workflow#501
mostlygeek merged 3 commits intomainfrom
claude/add-ui-tests-github-action-yVjcH

Conversation

@mostlygeek
Copy link
Copy Markdown
Owner

@mostlygeek mostlygeek commented Feb 1, 2026

Summary

This PR optimizes CI/CD workflows by adding path-based filters to reduce unnecessary workflow runs and introduces a new dedicated workflow for UI testing.

Key Changes

  • Go CI Workflows: Added path filters to go-ci.yml and go-ci-windows.yml to only trigger on changes to:

    • Go source files (**/*.go)
    • Go module files (go.mod, go.sum)
    • Build configuration (Makefile)
    • Excludes changes in cmd/** directory
  • New UI Test Workflow: Created ui-tests.yml workflow that:

    • Runs on changes to ui-svelte/** directory only
    • Sets up Node.js 23 with npm caching
    • Executes type checking (npm run check)
    • Runs test suite (npm test)
    • Uses ubuntu-latest runner

Benefits

  • Reduces CI/CD overhead by skipping unrelated workflow runs
  • Provides faster feedback for UI-specific changes
  • Maintains separate testing pipelines for Go backend and Svelte frontend
  • Improves developer experience with more targeted test execution

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7

Summary by CodeRabbit

  • Chores

    • CI workflows for Windows and Linux now only run for relevant backend source and build changes, reducing unnecessary runs.
    • Release workflow updated to use Node.js 24.
  • New Features

    • Added an automated UI testing workflow that runs type checks and frontend tests for UI changes.
  • Bug Fixes

    • Speech playground no longer stores/display generated text state, simplifying audio handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 1, 2026

Walkthrough

Adds path-based filters to Linux and Windows Go CI workflows, introduces a new "UI Tests" workflow for ui-svelte, bumps Node.js in the release workflow from 23 to 24, and removes generatedText and clearAudio handling from SpeechInterface.svelte.

Changes

Cohort / File(s) Summary
Go CI Path Filtering
\.github/workflows/go-ci.yml, \.github/workflows/go-ci-windows.yml
Added path filters to push and pull_request triggers: include **/*.go, exclude cmd/**, and explicitly include go.mod, go.sum, Makefile, and the workflow file(s).
UI Tests Workflow
\.github/workflows/ui-tests.yml
New workflow UI Tests targeting ui-svelte: triggers on pushes/PRs to main for ui-svelte/** and the workflow file; runs on ubuntu-latest, sets up Node.js 24, installs with npm ci, runs type checks and tests.
Release Workflow
\.github/workflows/release.yml
Updated Node.js setup from version 23 to 24.
UI Component
ui-svelte/src/components/playground/SpeechInterface.svelte
Removed generatedText state and its assignment/clearing; removed clearAudio() that revoked/cleared generated text and related state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding path filters to CI workflows and creating a new UI test workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/add-ui-tests-github-action-yVjcH

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add ui-tests.yml workflow to run svelte type checking and vitest
on push/PR to main when ui-svelte/ files change.

- Add path filters to go-ci.yml and go-ci-windows.yml to skip
  Go tests when only non-backend files change
- Filter on **/*.go, go.mod, go.sum, and Makefile

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
@mostlygeek mostlygeek force-pushed the claude/add-ui-tests-github-action-yVjcH branch from 63cc616 to a9dbce7 Compare February 1, 2026 19:14
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/ui-tests.yml:
- Around line 26-31: The workflow is using Node.js 23 which is end-of-life; edit
the GitHub Actions job that calls actions/setup-node@v4 and change the
node-version value from '23' to a supported release (preferably '24') so CI uses
Node.js 24; ensure the node-version: '23' line in the UI tests step is updated
to node-version: '24' (no other changes required).
🧹 Nitpick comments (1)
.github/workflows/go-ci-windows.yml (1)

8-13: Consider including workflow file changes in path filters.

Changes to .github/workflows/go-ci-windows.yml itself won't trigger this workflow. If workflow logic changes, you'd need to manually trigger via workflow_dispatch to verify the changes work correctly.

Consider adding the workflow file to the paths:

     paths:
       - '**/*.go'
       - '!cmd/**'
       - 'go.mod'
       - 'go.sum'
       - 'Makefile'
+      - '.github/workflows/go-ci-windows.yml'

Remove unused `generatedText` state and `clearAudio` function
that caused svelte-check errors.

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
Node 23 is end-of-life; bump to 24 in ui-tests.yml and release.yml.

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7
@mostlygeek mostlygeek merged commit 7b20fc0 into main Feb 1, 2026
3 of 4 checks passed
@mostlygeek mostlygeek deleted the claude/add-ui-tests-github-action-yVjcH branch March 22, 2026 23:56
rohitpaul pushed a commit to rohitpaul/llama-swap that referenced this pull request Mar 29, 2026
…eek#501)

* .github/workflows: add UI tests and path-filter Go CI

Add ui-tests.yml workflow to run svelte type checking and vitest
on push/PR to main when ui-svelte/ files change.

- Add path filters to go-ci.yml and go-ci-windows.yml to skip
  Go tests when only non-backend files change
- Filter on **/*.go, go.mod, go.sum, and Makefile

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7

* ui-svelte: remove unused declarations in SpeechInterface

Remove unused `generatedText` state and `clearAudio` function
that caused svelte-check errors.

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7

* .github/workflows: update Node.js to v24

Node 23 is end-of-life; bump to 24 in ui-tests.yml and release.yml.

https://claude.ai/code/session_01E6acq54D8JjuE7pczxPGT7

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants