Skip to content

proxy: skip very slow tests in -short test mode#446

Merged
mostlygeek merged 2 commits intomainfrom
speed-up-tests
Dec 31, 2025
Merged

proxy: skip very slow tests in -short test mode#446
mostlygeek merged 2 commits intomainfrom
speed-up-tests

Conversation

@mostlygeek
Copy link
Copy Markdown
Owner

@mostlygeek mostlygeek commented Dec 31, 2025

Improves dev test time from ~15s to ~10s. The full test suite is run for CI still.

Summary by CodeRabbit

  • Tests
    • Slow/integration tests made conditional on short-mode so they are skipped during quick test runs, speeding local development.
  • Documentation
    • Updated testing guidance: clarified test naming, recommended verbose test output, and added steps to run dev/all test targets when adding or finishing tests.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 31, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Added short-mode guards to three proxy package tests to skip slow scenarios when running with -short, and updated CLAUDE.md testing guidance with new lines about test naming and commands.

Changes

Cohort / File(s) Summary
Short-mode test guards
proxy/process_test.go, proxy/processgroup_test.go, proxy/proxymanager_test.go
Inserted testing.Short() checks to early-skip slow tests: TestProcess_ForceStopWithKill, TestProcessGroup_ProxyRequestSwapIsTrueParallel, and TestProxyManager_Shutdown.
Documentation update
CLAUDE.md
Replaced two testing guidance lines with four new lines emphasizing test naming (TestProxyManager_<name>), verbose go test output, and running make test-dev / make test-all during development.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

enhancement

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'proxy: skip very slow tests in -short test mode' clearly and specifically describes the main change: adding conditional skips to slow tests based on the testing.Short() flag across proxy test files.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00f71a0 and ffab3d0.

📒 Files selected for processing (1)
  • CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mostlygeek mostlygeek merged commit 3dc3603 into main Dec 31, 2025
2 of 3 checks passed
@mostlygeek mostlygeek deleted the speed-up-tests branch December 31, 2025 22:09
rohitpaul pushed a commit to rohitpaul/llama-swap that referenced this pull request Mar 29, 2026
* proxy: skip very slow tests in -short test mode
* CLAUDE.md: update testing instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant