Add endpoint aliases for reranking models#201
Conversation
WalkthroughTwo new reranking API endpoints, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md(1 hunks)proxy/proxymanager.go(1 hunks)
🔇 Additional comments (2)
proxy/proxymanager.go (1)
165-166: LGTM! New reranking endpoints added correctly.The implementation properly adds the
/v1/rerankingand/rerankendpoints with metrics tracking enabled, which aligns with the PR objectives to support RAGFlow requirements.README.md (1)
22-23: LGTM! Documentation properly updated.The new reranking endpoints are correctly documented in the OpenAI API supported endpoints list, maintaining consistency with the implementation changes.
|
@coderabbitai full review |
|
Tip For best results, initiate chat on the files or code changes. @gaelj I've received your requests for a full review and summary regeneration. The The Both automated processes will be initiated and you should see the results shortly. The full review will provide fresh analysis of your endpoint aliases implementation for the |
|
can RAGFlow work with v1/rerank or v1/reranking? I’d like to keep all proxied api calls under the v1/ path. |
|
Not without modifying their rerank method and submit the change in their repo. But, as the endpoint in question is specifically allowed in the llama-cpp docs as an alias, in my opinion adapting llama-swap is the better solution and will probably fix other people's similar issues with some other client software. I agree 100% that the choice of this endpoint alias seems to be a poor one, both from open AI and/or llama-cpp for allowing it and ragflow for using it exclusively, but unfortunately, like all cursed features, some people are going to rely on it. |
|
So OpenAI doesn’t even have a rerank api. Could you put all the rerank endpoints in one line for README changes? After that, I’ll merge. Thanks |
|
Great, thanks ! |
The
/rerankend point is needed by RAGFlow.These aliases are allowed in llama-cpp documentation
I have tested successfully the change.
Summary by CodeRabbit
New Features
Documentation