Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: position the dialog of the element-id-attribute based on its own parent #135

Merged
merged 5 commits into from
Aug 30, 2024
Merged

fix: position the dialog of the element-id-attribute based on its own parent #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60c7783
Updated Spelling mistake
dthvega Aug 30, 2024
0217f96
Merge pull request #134 from dthvega/patch-1
mostafaznv Aug 30, 2024
9078a37
GITBOOK-23: change request with no subject merged in GitBook
mostafaznv Aug 30, 2024
dfff1fa
fix: position the dialog of the element-id-attribute based on its own…
mostafaznv Aug 30, 2024
131165b
build: update assets
mostafaznv Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/field.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
* [Audio Naming Method](advanced-usage/configuration/audio-naming-method.md)
* [File Naming Method](advanced-usage/configuration/audio-naming-method-1.md)
* [Toolbars](advanced-usage/configuration/toolbars/README.md)
* [Defualt Toolbar](advanced-usage/configuration/toolbars/defualt-toolbar.md)
* [Default Toolbar](advanced-usage/configuration/toolbars/defualt-toolbar.md)
* [Toolbar 1](advanced-usage/configuration/toolbars/toolbar-1/README.md)
* [Height](advanced-usage/configuration/toolbars/toolbar-1/height.md)
* [Items](advanced-usage/configuration/toolbars/toolbar-1/items.md)
Expand Down
2 changes: 1 addition & 1 deletion docs/advanced-usage/configuration/toolbars/defualt-toolbar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
description: toolbars.default
---

# Defualt Toolbar
# Default Toolbar

| Property Name | Type | Default |
| ---------------- | ------ | ------------------------------------------- |
Expand Down
2 changes: 1 addition & 1 deletion resources/js/ckeditor/plugins/element-attribute/src/add-attribute-to-element-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class ElementAddAttributesUI extends Plugin {

if (!this._isInBalloon) {
const defaultPositions = BalloonPanelView.defaultPositions;
const target = document.querySelector('.element-add-attributes-btn');
const target = editor.ui.view.element.querySelector('.element-add-attributes-btn');

this._balloon.add({
view: this._form,
Expand Down