Merge pull request #88 from mostafaznv/dev

fix: source editing button causes disappearing editor
mostafaznv · Oct 25, 2023 · 9946931 · 9946931
2 parents 57e688a + acf3c2f
commit 9946931
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/dist/js/field.js b/dist/js/field.js
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
         "@ckeditor/ckeditor5-basic-styles": "^40.0.0",
         "@ckeditor/ckeditor5-block-quote": "^40.0.0",
         "@ckeditor/ckeditor5-code-block": "^40.0.0",
-        "@ckeditor/ckeditor5-dev-utils": "^39.1.0",
+        "@ckeditor/ckeditor5-dev-utils": "^39.2.0",
         "@ckeditor/ckeditor5-dev-webpack-plugin": "^31.1.13",
         "@ckeditor/ckeditor5-editor-classic": "^40.0.0",
         "@ckeditor/ckeditor5-essentials": "^40.0.0",

diff --git a/resources/js/components/editor-field.vue b/resources/js/components/editor-field.vue
@@ -96,13 +96,6 @@ export default {
                         priority: 'lowest'
                     })
 
-                    // set the height of the editor when editing
-                    if (this.currentField.height > 1) {
-                        editor.editing.view.change(writer => {
-                            writer.setStyle('height', `${this.currentField.height}px`, editor.editing.view.document.getRoot());
-                        });
-                    }
-
                     editor.editing.view.change((writer) => {
                         // set the height of the editor when editing
                         if (this.currentField.height > 1) {
@@ -254,7 +247,9 @@ export default {
                 debounce((element) => {
                     const height = element[0].target.offsetHeight
 
-                    writer.setStyle('height', `${height}px`, editor.editing.view.document.getRoot())
+                    if (height > 10) {
+                        writer.setStyle('height', `${height}px`, editor.editing.view.document.getRoot())
+                    }
                 }, 100),
             )