Merge pull request #135 from mostafaznv/dev

fix: position the dialog of the element-id-attribute based on its own parent
mostafaznv · Aug 30, 2024 · 0536fb8 · 0536fb8
2 parents b555bf1 + 131165b
commit 0536fb8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/dist/js/field.js b/dist/js/field.js
diff --git a/docs/SUMMARY.md b/docs/SUMMARY.md
@@ -46,7 +46,7 @@
   * [Audio Naming Method](advanced-usage/configuration/audio-naming-method.md)
   * [File Naming Method](advanced-usage/configuration/audio-naming-method-1.md)
   * [Toolbars](advanced-usage/configuration/toolbars/README.md)
-    * [Defualt Toolbar](advanced-usage/configuration/toolbars/defualt-toolbar.md)
+    * [Default Toolbar](advanced-usage/configuration/toolbars/defualt-toolbar.md)
     * [Toolbar 1](advanced-usage/configuration/toolbars/toolbar-1/README.md)
       * [Height](advanced-usage/configuration/toolbars/toolbar-1/height.md)
       * [Items](advanced-usage/configuration/toolbars/toolbar-1/items.md)

diff --git a/docs/advanced-usage/configuration/toolbars/defualt-toolbar.md b/docs/advanced-usage/configuration/toolbars/defualt-toolbar.md
@@ -2,7 +2,7 @@
 description: toolbars.default
 ---
 
-# Defualt Toolbar
+# Default Toolbar
 
 | Property Name    | Type   | Default                                     |
 | ---------------- | ------ | ------------------------------------------- |

diff --git a/resources/js/ckeditor/plugins/element-attribute/src/add-attribute-to-element-ui.js b/resources/js/ckeditor/plugins/element-attribute/src/add-attribute-to-element-ui.js
@@ -106,7 +106,7 @@ class ElementAddAttributesUI extends Plugin {
 
         if (!this._isInBalloon) {
             const defaultPositions = BalloonPanelView.defaultPositions;
-            const target = document.querySelector('.element-add-attributes-btn');
+            const target = editor.ui.view.element.querySelector('.element-add-attributes-btn');
 
             this._balloon.add({
                 view: this._form,