BasisImporter,CgltfImporter: don't zero-init the arrays before a copy.

This basically makes the copy twice as slow. Can be quite significant, especially with large files.
mosra · Oct 25, 2021 · 809fc18 · 809fc18
1 parent 7a1b1a8
commit 809fc18
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/MagnumPlugins/BasisImporter/BasisImporter.cpp b/src/MagnumPlugins/BasisImporter/BasisImporter.cpp
@@ -209,7 +209,7 @@ void BasisImporter::doOpenData(Containers::Array<char>&& data, DataFlags dataFla
     if(dataFlags & (DataFlag::Owned|DataFlag::ExternallyOwned)) {
         _state->in = std::move(data);
     } else {
-        _state->in = Containers::Array<char>{data.size()};
+        _state->in = Containers::Array<char>{NoInit, data.size()};
         Utility::copy(data, _state->in);
     }
 }

diff --git a/src/MagnumPlugins/CgltfImporter/CgltfImporter.cpp b/src/MagnumPlugins/CgltfImporter/CgltfImporter.cpp
@@ -527,7 +527,7 @@ void CgltfImporter::doOpenData(Containers::Array<char>&& data, const DataFlags d
     if(dataFlags & (DataFlag::Owned|DataFlag::ExternallyOwned)) {
         _d->fileData = std::move(data);
     } else {
-        _d->fileData = Containers::Array<char>{data.size()};
+        _d->fileData = Containers::Array<char>{NoInit, data.size()};
         Utility::copy(data, _d->fileData);
     }