Use the COMPILE_LANGUAGE CMake genexp instead of LINKER_LANGUAGE #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent ages looking for a COMPILE_LANGUAGE CMake target property, it
was just not there. Obviously it wasn't, because this is different on a
per-file basis, it's a generator expression on its own.
With this, the Corrade pedantic flags should no longer cause annoying
warning when used with targets that mix C and C++.
Unfortunately, in CMake 3.11 and older, if the projects uses just C or
CXX, the thing will fail with an error that the language is unknown,
which makes it useless. Thus gotta wait with this until 3.12 is the
minimum supported:
https://gitlab.kitware.com/cmake/cmake/-/commit/4f82199befee194aa924fd4dcdb2f4aad1f7dab6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the Corrade pedantic flags should no longer cause annoying warning when used with targets that mix C and C++.
Unfortunately, in CMake 3.11 and older, if the projects use just C or CXX, the thing will fail with an error that the language is unknown, which makes it useless. Thus gotta wait with this until 3.12 is the minimum supported: https://gitlab.kitware.com/cmake/cmake/-/commit/4f82199befee194aa924fd4dcdb2f4aad1f7dab6