Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify sms api proto #982

Merged
merged 2 commits into from
Aug 18, 2023
Merged

feat: modify sms api proto #982

merged 2 commits into from
Aug 18, 2023

Conversation

alilestera
Copy link
Contributor

What this PR does:
modify sms api proto and generate its docs

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions
Copy link

Hi @alilestera. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6498f86) 60.18% compared to head (022c582) 60.18%.

❗ Current head 022c582 differs from pull request most recent head 3c2ece7. Consider uploading reports for the commit 3c2ece7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         143      143           
  Lines       10009    10009           
=======================================
  Hits         6024     6024           
  Misses       3205     3205           
  Partials      780      780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhenjunMa zhenjunMa merged commit 1694e7a into mosn:main Aug 18, 2023
@alilestera alilestera deleted the feat-sms-proto branch October 3, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants