Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when running WASM quickstart #839

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

rayowang
Copy link
Member

@rayowang rayowang commented Nov 3, 2022

What this PR does:
fix error when running WASM quickstart

Which issue(s) this PR fixes:

Fixes #838

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes question Further information is requested size/S labels Nov 3, 2022
This reverts commit a7bf9fb.
zhenjunMa
zhenjunMa previously approved these changes Nov 3, 2022
@seeflood
Copy link
Member

seeflood commented Nov 3, 2022

@rayowang
Copy link
Member Author

rayowang commented Nov 3, 2022

@seeflood I just fixed it. The error printed by this GetRandomPluginByID should be placed in the outer call, otherwise the install or uninstall will definitely print an error once.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 60.72% // Head: 60.82% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (808b516) compared to base (72487fd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   60.72%   60.82%   +0.09%     
==========================================
  Files         137      137              
  Lines        9101     9103       +2     
==========================================
+ Hits         5527     5537      +10     
+ Misses       2887     2879       -8     
  Partials      687      687              
Impacted Files Coverage Δ
pkg/wasm/dispatch.go 23.80% <100.00%> (ø)
pkg/wasm/factory.go 24.35% <100.00%> (+6.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seeflood seeflood enabled auto-merge (squash) November 3, 2022 11:46
@seeflood seeflood merged commit 959bb1d into mosn:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes question Further information is requested size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running WASM quickstart; 修复 wasm quickstart 中的报错
3 participants