Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add xds v3 default config #835

Merged
merged 5 commits into from
Nov 2, 2022
Merged

fix: add xds v3 default config #835

merged 5 commits into from
Nov 2, 2022

Conversation

rayowang
Copy link
Member

@rayowang rayowang commented Nov 1, 2022

What this PR does:
I just took the task of integrating istio 1.10 #664 and fixed #700 by the way
Which issue(s) this PR fixes:

Fixes #700

@rayowang rayowang changed the title add xds v3 default config fix: add xds v3 default config Nov 1, 2022
@mosn-community-bot mosn-community-bot bot added cla:yes size/M bug Something isn't working and removed size/M labels Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 60.72% // Head: 60.72% // No change to project coverage 👍

Coverage data is based on head (9d91a0a) compared to base (1ac8b44).
Patch has no changes to coverable lines.

❗ Current head 9d91a0a differs from pull request most recent head 37b3f5d. Consider uploading reports for the commit 37b3f5d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   60.72%   60.72%           
=======================================
  Files         137      137           
  Lines        9101     9101           
=======================================
  Hits         5527     5527           
  Misses       2887     2887           
  Partials      687      687           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood enabled auto-merge (squash) November 2, 2022 07:44
@seeflood seeflood merged commit 72487fd into mosn:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: errors occur during startup; 启动时有报错
3 participants