Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): sms api #814

Merged
merged 2 commits into from
Oct 19, 2022
Merged

feat(api): sms api #814

merged 2 commits into from
Oct 19, 2022

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood [email protected]

What this PR does:
sms api

Which issue(s) this PR fixes:

Fixes #716

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 60.55% // Head: 60.55% // No change to project coverage 👍

Coverage data is based on head (41e8118) compared to base (0629c4e).
Patch has no changes to coverable lines.

❗ Current head 41e8118 differs from pull request most recent head bafc9ee. Consider uploading reports for the commit bafc9ee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   60.55%   60.55%           
=======================================
  Files         135      135           
  Lines        8815     8815           
=======================================
  Hits         5338     5338           
  Misses       2823     2823           
  Partials      654      654           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood
Copy link
Member Author

@wlwilliamx @wenxuwan Hi, I found that you guys added some fields in the oss.proto but forgot to modify the oss.pb.go
image

I regenerated oss.pb.go in this PR. Please make sure it's ok.
image

@seeflood seeflood merged commit 10b0313 into mosn:main Oct 19, 2022
@seeflood seeflood deleted the sms branch October 19, 2022 05:25
Copy link
Member

@kevinten10 kevinten10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: SMS notify API [SaaS API]
4 participants