Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect conversion between integer types #789

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Sep 14, 2022

Signed-off-by: Xunzhuo [email protected]

What this PR does:

Incorrect conversion of an integer with architecture-dependent bit size from strconv.Atoi to a lower bit size type int32 without an upper bound check.

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/XS labels Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (8bc1048) compared to base (5f65f47).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8bc1048 differs from pull request most recent head fbf236a. Consider uploading reports for the commit fbf236a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           
Impacted Files Coverage Δ
components/rpc/invoker/mosn/mosninvoker.go 72.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit 6e08652 into mosn:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants