Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add DelayQueue API #786

Merged
merged 2 commits into from
Sep 28, 2022
Merged

feat(api): add DelayQueue API #786

merged 2 commits into from
Sep 28, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Sep 14, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
add DelayQueue API

Which issue(s) this PR fixes:

Fixes #617

Special notes for your reviewer:
Please focus on reviewing the delay_queue.proto first. All the other files are generated by generator

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (dc13987) compared to base (187de61).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 14, 2022

What caused the quickstart task always failed? Any ideas?

@seeflood
Copy link
Member Author

What caused the quickstart task always failed? Any ideas?

It's caused by the java sdk compilation erorrs. I submitted a PR #787 to fix it

kevinten10
kevinten10 previously approved these changes Sep 23, 2022
Copy link
Member

@kevinten10 kevinten10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seeflood seeflood merged commit b07ff39 into mosn:main Sep 28, 2022
@seeflood seeflood deleted the delay_queue branch September 28, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: pubsub api add delay message support
5 participants