Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify component configuration during runtime #762

Merged
merged 37 commits into from
Aug 30, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Aug 12, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
modify component configuration during runtime

  • implement lifecycle API
  • add a demo component
  • generate api reference doc
  • fix license
  • add a quickstart document
  • add the quickstart doc into the CI
  • add the quickstart doc into the sidebar
  • add more test cases

Which issue(s) this PR fixes:

Fixes #500

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Base: 60.61% // Head: 60.65% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (2f686e2) compared to base (79772ee).
Patch coverage: 76.66% of modified lines in pull request are covered.

❗ Current head 2f686e2 differs from pull request most recent head 2d8f5fd. Consider uploading reports for the commit 2d8f5fd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   60.61%   60.65%   +0.04%     
==========================================
  Files         133      133              
  Lines        8327     8355      +28     
==========================================
+ Hits         5047     5068      +21     
- Misses       2704     2711       +7     
  Partials      576      576              
Impacted Files Coverage Δ
pkg/runtime/runtime.go 60.76% <68.18%> (+0.44%) ⬆️
components/hello/helloworld/helloworld.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood changed the title [WIP] feat: modify component configuration during runtime feat: modify component configuration during runtime Aug 15, 2022
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood
Copy link
Member Author

I will add the documentation in some other PR, after developing the doc-generator.

zhenjunMa
zhenjunMa previously approved these changes Aug 19, 2022
pkg/grpc/lifecycle/grpc_api.go Outdated Show resolved Hide resolved
pkg/grpc/lifecycle/grpc_api.go Outdated Show resolved Hide resolved
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
pkg/grpc/lifecycle/grpc_api.go Outdated Show resolved Hide resolved
pkg/runtime/lifecycle/types.go Show resolved Hide resolved
Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeflood seeflood merged commit 2021157 into mosn:main Aug 30, 2022
@seeflood seeflood deleted the update_config branch August 30, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置下发通道与配置热加载
4 participants