Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move s3 pb to specify directory #758

Merged
merged 6 commits into from
Aug 8, 2022
Merged

fix: move s3 pb to specify directory #758

merged 6 commits into from
Aug 8, 2022

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented Aug 8, 2022

What this PR does:

修改pb文件的路径,不然后续的拓展协议包名都得叫s3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@wenxuwan wenxuwan changed the title move s3 pb to specify directory fix: move s3 pb to specify directory Aug 8, 2022
@mosn-community-bot mosn-community-bot bot added the bug Something isn't working label Aug 8, 2022
zhenjunMa
zhenjunMa previously approved these changes Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #758 (85344c6) into main (3fc2919) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8323     8323           
=======================================
  Hits         5041     5041           
  Misses       2705     2705           
  Partials      577      577           
Impacted Files Coverage Δ
pkg/grpc/extension/s3/s3.go 62.01% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

demo/oss/client.go Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit daef3c3 into mosn:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants