-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move s3 pb to specify directory #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenxuwan
changed the title
move s3 pb to specify directory
fix: move s3 pb to specify directory
Aug 8, 2022
zhenjunMa
previously approved these changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 133 133
Lines 8323 8323
=======================================
Hits 5041 5041
Misses 2705 2705
Partials 577 577
Help us with your feedback. Take ten seconds to tell us how you rate us. |
seeflood
requested changes
Aug 8, 2022
zhenjunMa
approved these changes
Aug 8, 2022
seeflood
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
修改pb文件的路径,不然后续的拓展协议包名都得叫s3
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: