-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify istio version& add layotto_without_xds
#714
Conversation
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
# Conflicts: # cmd/layotto/main.go
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 60.89% 60.89%
=======================================
Files 122 122
Lines 6432 6432
=======================================
Hits 3917 3917
Misses 2133 2133
Partials 382 382 Continue to review full report at Codecov.
|
Signed-off-by: seeflood [email protected]
What this PR does:
modify istio version in main.go
I used to modify istio version with Makefile, but I reverted it because I want the makefile script decoupled with the code.
For example, if the code doesn't import xDS related packages, makefile will get error when trying to modify the istio version.
add
layotto_without_xds
for non-xDS usersWhich issue(s) this PR fixes:
Fixes #
It's subtask of #471
Special notes for your reviewer:
Does this PR introduce a user-facing change?: